This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Change bitswap provide toggle to not be static #124
Merged
+57
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelavila
force-pushed
the
experiment/provider-system-no-blocks-no-static-config
branch
from
33e86ee
to
b291bbd
Compare
Stebalien
reviewed
May 15, 2019
hannahhoward
suggested changes
May 15, 2019
There was a problem hiding this comment.
Agree with @Stebalien about functional options or other config param, otherwise LGTM, though you better rebase cause I think you might find there's a fair amount to change.
michaelavila
force-pushed
the
experiment/provider-system-no-blocks-no-static-config
branch
4 times, most recently
from
9811fd0
to
b220a70
Compare
|
@hannahhoward / @Stebalien this is good to review/merge if acceptable. |
Stebalien
approved these changes
May 18, 2019
|
But it needs a go fmt to pass CI. |
michaelavila
force-pushed
the
experiment/provider-system-no-blocks-no-static-config
branch
from
b220a70
to
2bfcdb0
Compare
michaelavila
force-pushed
the
experiment/provider-system-no-blocks-no-static-config
branch
from
2bfcdb0
to
0bae16c
Compare
michaelavila
changed the title
michaelavila
force-pushed
the
experiment/provider-system-no-blocks-no-static-config
branch
6 times, most recently
from
c26654e
to
ea56b5d
Compare
michaelavila
commented
May 20, 2019
Stebalien
reviewed
May 20, 2019
michaelavila
force-pushed
the
experiment/provider-system-no-blocks-no-static-config
branch
2 times, most recently
from
2a49b72
to
51d2266
Compare
michaelavila
force-pushed
the
experiment/provider-system-no-blocks-no-static-config
branch
from
51d2266
to
94b505a
Compare
michaelavila
deleted the
experiment/provider-system-no-blocks-no-static-config
branch
Jorropo
pushed a commit
to Jorropo/go-libipfs
that referenced
this pull request
Jan 26, 2023
…system-no-blocks-no-static-config Change bitswap provide toggle to not be static This commit was moved from ipfs/go-bitswap@07a235d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.